Skip to content

Conversation

@Tomi-3-0
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Unit Test Results

       12 files  ±0    2 432 suites  ±0   48m 8s ⏱️ +45s
12 658 tests +1  12 093 ✔️ +1  565 💤 ±0  0 ±0 
63 636 runs  +4  62 908 ✔️ +4  728 💤 ±0  0 ±0 

Results for commit 1b3cbc3. ± Comparison against base commit 3aa47a7.

♻️ This comment has been updated with latest results.

@Tomi-3-0 Tomi-3-0 marked this pull request as ready for review November 24, 2025 08:47
@Tomi-3-0 Tomi-3-0 requested a review from tersec November 24, 2025 08:47
@Tomi-3-0 Tomi-3-0 changed the title Add PayloadAttestaition message support to web3signer Add PayloadAttestation message support to web3signer Nov 24, 2025
Copy link
Contributor

@cheatfate cheatfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debugging echoes.

@tersec
Copy link
Contributor

tersec commented Nov 25, 2025

Where are the specs for this defined?

@Tomi-3-0
Copy link
Contributor Author

Where are the specs for this defined?

That's correct, the Web3Signer specs doesn't officially support it yet. this is getting ahead of the official specs. I will limit this to local signing

@Tomi-3-0 Tomi-3-0 changed the title Add PayloadAttestation message support to web3signer Add getPayloadAttestationSignature for local signing Nov 25, 2025
@tersec tersec merged commit 6232605 into unstable Nov 25, 2025
11 checks passed
@tersec tersec deleted the ZxY branch November 25, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants