Skip to content

LC: Switch to pluggable backend for LC updates #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Draft

LC: Switch to pluggable backend for LC updates #7704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions beacon_chain/sync/light_client_manager.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,31 @@ type
GetSyncCommitteePeriodCallback* =
proc(): SyncCommitteePeriod {.gcsafe, raises: [].}

LightClientBootstrapProc = proc(
id: uint64, blockRoot: Eth2Digest
): Future[NetRes[ForkedLightClientBootstrap]] {.async: (raises: [CancelledError]).}
LightClientUpdatesByRangeProc = proc(
id: uint64, startPeriod: SyncCommitteePeriod, count: uint64
): Future[LightClientUpdatesByRangeResponse] {.async: (raises: [CancelledError]).}
LightClientFinalityUpdateProc = proc(
id: uint64
): Future[NetRes[ForkedLightClientFinalityUpdate]] {.
async: (raises: [CancelledError])
.}
LightClientOptimisticUpdateProc = proc(
id: uint64
): Future[NetRes[ForkedLightClientOptimisticUpdate]] {.
async: (raises: [CancelledError])
.}
UpdateScoreProc = proc(id: uint64, value: int) {.gcsafe, raises: [].}

EthLCBackend* = object
Copy link
Contributor

@kdeme kdeme Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light client naming is already sufficiently confusing with all the types of light clients.

I would suggest to either stick here with naming scheme of the existing file: LightClientBackend.
Or to call it ConsensusLightClientBackend

getLightClientBootstrap*: LightClientBootstrapProc
getLightClientUpdatesByRange*: LightClientUpdatesByRangeProc
getLightClientFinalityUpdate*: LightClientFinalityUpdateProc
getLightClientOptimisticUpdate*: LightClientOptimisticUpdateProc
updateScore*: UpdateScoreProc

LightClientManager* = object
network: Eth2Node
rng: ref HmacDrbgContext
Expand Down
Loading