Trace invalid blocks in unviable quarantine #7685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A block may become unviable for two main reasons: * the fork it was on is orphaned by chain finality - ie the block was valid in some history, but not any more in the canonical one * the block is invalid, either because it is itself invalid or it builds on an invalid block Until now we've treated both kinds the same when it comes to the `unviable` quarantine - because of this, when checking gossip rules the client has in some cases opted for the more lenient "IGNORE" respons instead of using "REJECT". This PR brings the client more closely in line with ignore/reject rules by tracking the original error that led to the unviablility. * use `minilru` instead of `OrderedTable` for simplified capacity management and performance * simplify quarantine operations that deal with unviables * remove unused quarantine events * keep track of the block being processed to avoid it being readded to the quarantine during processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A block may become unviable for two main reasons:
Until now we've treated both kinds the same when it comes to the
unviablequarantine - because of this, when checking gossip rules the client has in some cases opted for the more lenient "IGNORE" respons instead of using "REJECT".This PR brings the client more closely in line with ignore/reject rules by tracking the original error that led to the unviablility.
minilruinstead ofOrderedTablefor simplified capacity management and performance