Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #6374

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Conversation

renshuncui
Copy link

No description provided.

Signed-off-by: renshuncui <[email protected]>
@tersec
Copy link
Contributor

tersec commented Jun 21, 2024

Needs to target the unstable branch

@renshuncui renshuncui changed the base branch from stable to unstable July 24, 2024 11:25
@renshuncui
Copy link
Author

Needs to target the unstable branch

Thanks. Modified

@tersec
Copy link
Contributor

tersec commented Jul 24, 2024

One of the files you modified also therefore needs a copyright year update, which is otherwise causing the linting CI check to fail:

Run excluded_files="config.yaml"
The following files do not have an up-to-date copyright year:
- scripts/signers/web3signer.sh
Error: Process completed with exit code 2.

# Copyright (c) 2023 Status Research & Development GmbH.

should read

# Copyright (c) 2023-2024 Status Research & Development GmbH.

Copy link

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 35s ⏱️ -12s
  4 999 tests ±0    4 651 ✔️ ±0  348 💤 ±0  0 ±0 
20 877 runs  ±0  20 473 ✔️ ±0  404 💤 ±0  0 ±0 

Results for commit 8af4743. ± Comparison against base commit fd4398d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants