fCU early notification of finalized hash to FC. #3204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before fCU actually call FC.forkchoice, it will go through a series of validation, and the finalized hash may never arrive at FC.forkChoice at all although the finalized hash is valid. e.g. head, finalized, or safe block are being downloaded by the syncer.
arnetheduck
reviewed
Apr 10, 2025
| @@ -109,6 +108,7 @@ proc forkchoiceUpdated*(ben: BeaconEngineRef, | |||
| hash = headHash.short | |||
|
|
|||
| # Inform the header cache (used by the syncer) | |||
| chain.notifyFinalizedHash(update.finalizedBlockHash) | |||
There was a problem hiding this comment.
should also update latestFinalizedBlockNumber with max(latestFinalizedBlockNumber, newNumber) ..
also, should set latestFCU even if we can't find the number
|
while this PR fixes the urgent base update issue, many of the checks and updates performed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fCU actually call FC.forkchoice, it will go through a series of validation, and the finalized hash may never arrive at FC.forkChoice at all although the finalized hash is valid. e.g. head, finalized, or safe block are being downloaded by the syncer.