Open
Conversation
Following the acceptance of nim-lang/RFCs#557, `except:` now has mostly well-defined behavior. Also add `gcsafe` to `push` recommendation which improves error messages overall.
Ivansete-status
approved these changes
Jul 14, 2025
Contributor
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! 🙌
Just two minor questions
| @@ -1,4 +1,4 @@ | |||
| {.push raises: [].} | |||
| {.push raises: [], gcsafe.} | |||
Contributor
There was a problem hiding this comment.
Why gcsafe needed?
Member
Author
There was a problem hiding this comment.
gcsafe is already needed for all async functions (enforced by chronos) - putting it in push improves the error message to show the source of the violation.
| # Enable exception tracking for all functions in this module | ||
| `{.push raises: [].}` # Always at start of module | ||
| # Enable exception and gcsafe tracking for all functions in this module | ||
| `{.push raises: [], gcsafe.}` # Always at start of module |
Contributor
There was a problem hiding this comment.
Is the recommendation to add this at the beginning of each module? I wonder if there could be a global config that does it by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the acceptance of nim-lang/RFCs#557,
except:now has mostly well-defined behavior.Also add
gcsafetopushrecommendation which improves error messages overall.