Skip to content

make SomeFuture public #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make SomeFuture public #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chronos/internal/asyncfutures.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ type
FutureCompletedError* = object of FutureError
## Error raised when trying access the error of a completed Future

SomeFuture = Future|InternalRaisesFuture
SomeFuture* = Future|InternalRaisesFuture
Copy link
Member

@arnetheduck arnetheduck Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type is deliberately private because the whole idea of how this is implemented might change soonish - for now, it's better to use InternalRaisesFuture directly in code that needs it which will make it easy to find, once a stable future type is created.


func raiseFuturePendingError(fut: FutureBase) {.
noinline, noreturn, raises: FuturePendingError.} =
Expand Down