Skip to content

Properly handles overflow integers. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Properly handles overflow integers. #51

wants to merge 49 commits into from
+44 −23

Conversation

chaburkland
Copy link
Collaborator

Refs #50

@chaburkland chaburkland added the bug Something isn't working label Jun 8, 2021
@chaburkland chaburkland self-assigned this Jun 8, 2021
brandtbucher
brandtbucher requested changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think I found one bug, and the rest is just minor comments and cleanup:

chaburkland and others added 19 commits June 9, 2021 16:48
@chaburkland @brandtbucher
Update test/test_util.py
ca8b822 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
3f67876 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
f916fdd 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
f2a14eb 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
5d24633 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
83618f1 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
910b978 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
34309ef 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
135d10b 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland @brandtbucher
Update src/_arraykit.c
086c6ba 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland
Fixes syntax bug from merge suggestion.
54bd85f
@chaburkland
Fixes incorrect mid-range boundaries.
021518d
@chaburkland
Yet another attempt to fix this cursed test.
dcf9244
@chaburkland
Another attempt >:|
33cc3c2
@chaburkland
Attempt to be inclusive of 32bit architectures.
078a00a
@chaburkland
Updates error message. Why does anyone have 32bit machines?
cc9d8f7
@chaburkland
More commits to use github to debug 32bit errors since I cant do it l…
b22f42a 
…ocally.
@chaburkland
:|
5c8d496
@chaburkland
This will fail. I need more iinfo.
2710778
brandtbucher
brandtbucher requested changes Jun 10, 2021
View reviewed changes
brandtbucher
brandtbucher reviewed Jun 10, 2021
View reviewed changes
@brandtbucher
Copy link
Collaborator

It looks like you use it below for str and bytes, haha!

@chaburkland @brandtbucher
Update src/_arraykit.c
6d4fefd 
Co-authored-by: Brandt Bucher <[email protected]>
@chaburkland chaburkland requested a review from brandtbucher June 17, 2021 18:18
@brandtbucher brandtbucher removed their request for review November 17, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

@flexatone flexatone Awaiting requested review from flexatone

Assignees

@chaburkland chaburkland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaburkland @brandtbucher