Skip to content

Throw exception if network is not working #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Throw exception if network is not working #19

wants to merge 2 commits into from

Conversation

MaurizioK
Copy link

@MaurizioK MaurizioK commented May 29, 2024 •
edited
Loading

@MaurizioK MaurizioK requested a review from a team May 29, 2024 16:17
@MaurizioK MaurizioK marked this pull request as ready for review June 25, 2024 12:28
MarcoStatespace
MarcoStatespace reviewed Jun 25, 2024
View reviewed changes
Runtime/SimpleGraphQL/HttpUtils.cs
@@ -131,6 +131,7 @@ public static void Dispose()
if (webRequest.result == UnityWebRequest.Result.ConnectionError)
{
Debug.LogError("Error While Sending: " + webRequest.error);
throw new UnityWebRequestException(webRequest);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this make the console to crash?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 177 there is the same thing (already there since the dawn of time).

If the flow I've found is the only one possible, then this exception is catched by our GraphQL utility, the good ol' Query_Internal method. Since it's a managed exception it shouldn't make the console crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoStatespace MarcoStatespace MarcoStatespace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaurizioK @MarcoStatespace