Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Svelte 5 to the allowed peer dependency range #5131

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

lendle
Copy link
Contributor

@lendle lendle commented Nov 28, 2024

Svelte 5 is "almost" entirely backwards compatible with svelte 4. Breaking changes can be found here.

@xstate/svelte only uses onDestroy, readable, and Readable from svelte, which are backwards compatible.

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 48b3443

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lendle
Copy link
Contributor Author

lendle commented Nov 28, 2024

There are some failing svelte related tests, but I think this is coincidental, they're also failing in main. I created the branch from the last working commit on main (65088b6) and it works locally. So I think the ci build will succeed once main is fixed.

@Andarist
Copy link
Member

Would you be willing to help out with fixing those tests on main?

@lendle
Copy link
Contributor Author

lendle commented Nov 28, 2024

Wish I could! I just tried a handful of things but no luck. I don't know anything about jest or babel so don't really know how to debug.

@lendle
Copy link
Contributor Author

lendle commented Dec 19, 2024

Build seems to be working now after syncing my fork if anyone is available to review. cc @Andarist

@Andarist Andarist changed the title Bump svelte version to include svelte 5 Add Svelte 5 to the allowed peer dependency range Dec 19, 2024
@Andarist Andarist merged commit 55ffd69 into statelyai:main Dec 19, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@lendle
Copy link
Contributor Author

lendle commented Dec 19, 2024

🙇 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants