First class dagger shell #1947
Merged
First class dagger shell #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
approved these changes
Feb 6, 2025
sourishkrout
added a commit
to stateful/runme
that referenced
this pull request
Feb 6, 2025
In order to natively support Dagger's shell Runme needs to take the entire notebook as opposed to an atomic cell into account. This PR introduces the APIs necessary to transform a notebook into a Dagger Shell script using some basic AST transformation. Integration with extension in stateful/vscode-runme#1947. PS: The protos are not published yet and need local-gen to work. The new service will turn a deserialized version of the following markdown into a runnable Dagger shell script. ## Simple example notebook Unamed cell: ```sh {"closeTerminalOnSuccess":"false","interactive":"true","openTerminalOnError":"true","terminalRows":"23"} git github.com/stateful/runme | head | tree | file examples/README.md ``` And the same as a named cell: ```sh {"name":"README"} # Named in README in cell attributes git github.com/stateful/runme | head | tree | file examples/README.md ``` ## Resulting Dagger Shell Script Running the unamed cell: ```sh DAGGER_01JKE40B6A0F5NBESE49X122RD() { git github.com/stateful/runme \ | head \ | tree \ | file examples/README.md } DAGGER_01JKE40B6A0F5NBESE49X122RD ``` Running the named cell: ```sh DAGGER_01JKE4K781F87XRK9SQZ9T1GQD() { git github.com/stateful/runme \ | head \ | tree \ | file examples/README.md } README() { git github.com/stateful/runme | head | tree | file examples/README.md } README ```
sourishkrout
force-pushed
the
seb/first-class-dagger-shell
branch
2 times, most recently
from
4a62c34 to
391a31b
Compare
sourishkrout
force-pushed
the
seb/first-class-dagger-shell
branch
from
bf53039 to
a898b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates with the new Kernel APIs to transform a notebook into a working Dagger Shell script on-demand.
Currently this will only happen if the notebook's shell is set to
dagger shellas part of the frontmatter. In a separate PR we might also default based on file extensions (e.g..dag).This PR requires stateful/runme#736 with local-gen protos to work. An example notebook is committed here: 7ed343c.
PS: Tests might fail. Will work on fixing them.