Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native xvfb #1452

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Use native xvfb #1452

merged 2 commits into from
Jul 1, 2024

Conversation

peraltafederico
Copy link
Contributor

@peraltafederico peraltafederico commented Jun 29, 2024

Use native xvfb instead of coactions/setup-xvfb@v1 because it's failing for GH pipelines. See coactions/setup-xvfb#19

Copy link

@pastuxso
Copy link
Contributor

pastuxso commented Jul 1, 2024

@peraltafederico Unfortunately, Our Github Action lacks graceful termination, causing a false negative.

I favor this PR to avoid future confusion with false negatives with this GitHub Action.

Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peraltafederico peraltafederico merged commit 15aa6ba into main Jul 1, 2024
4 checks passed
@peraltafederico peraltafederico deleted the fede/xvfb branch July 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants