Retain markdown's fenced code block encoding format #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sourishkrout Initially I wanted to comment with suggestions, but as the number of comments was growing, I submitted 5d0f828 instead. The main change is removal of the |
adambabik
approved these changes
Feb 3, 2025
sourishkrout
changed the base branch from
adamb/cleanup-attributes-parsing
to
main
Sounds good 👌. Thank you! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all tools processing markdowns equally accommodate attributes/annotations inside fenced code blocks. This is especially true if they aren't encoded in HTML attribute format. A notable example is https://gohugo.io/.
Instead of always preferring
JSONencoding. This PR changes the default behavior of the attribute parser to retain the original encoding format.