Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds sonarcloud setup #460

Merged
merged 2 commits into from
Dec 29, 2023
Merged

adds sonarcloud setup #460

merged 2 commits into from
Dec 29, 2023

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Dec 29, 2023 •
edited
Loading

Adds setup to start using SonarCloud, Analysis will be performed manually through GitHub Actions.

@pastuxso pastuxso force-pushed the cepeda/sonarcloud branch 5 times, most recently from c5c123c to d85daed Compare December 29, 2023 15:53
@pastuxso pastuxso marked this pull request as ready for review December 29, 2023 16:06
@pastuxso pastuxso changed the title adds initial sonarcloud setup adds sonarcloud setup Dec 29, 2023
adambabik
adambabik reviewed Dec 29, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pastuxso pastuxso requested a review from adambabik December 29, 2023 20:25
sourishkrout
sourishkrout approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sourishkrout sourishkrout removed the request for review from adambabik December 29, 2023 21:34
@pastuxso pastuxso merged commit 1aa308e into main Dec 29, 2023
6 checks passed
@pastuxso pastuxso deleted the cepeda/sonarcloud branch December 29, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

@adambabik adambabik adambabik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pastuxso @sourishkrout @adambabik