Add session metadata to serialization + frontmatter #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourishkrout
force-pushed
the
session-metadata
branch
from
43dee07 to
5cdf62b
Compare
pastuxso
reviewed
Dec 28, 2023
|
|
||
| serializeOptions := &parserv1.SerializeRequestOptions{Outputs: &parserv1.SerializeRequestOutputOptions{Enabled: true, Summary: true}} | ||
| prasedFm := "---\nrunme:\n id: 01HF7B0KK32HBQ9X4AC2GPMZG5\n version: v2.0\nsidebar_position: 1\ntitle: Examples\n---" |
There was a problem hiding this comment.
Thanks! Totally a typo. Fixed it.
pastuxso
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the extension to deny the notebook UX for markdown files written as session outputs until deserialization has been implemented (currently one-way; serialization only).
Chose to pass the session output metadata as option separately (not modifying frontmatter directly) because as long as outputs serialization is one-way, the extension uses two serializer runs (original markdown + session outputs markdown). If we decided we won't ever support outputs deserialization, we could create a separate operation. However, let's not jump ahead.
These changes are required for stateful/vscode-runme#1025.