Dagger Shell output is not ready for UX integration

stateful · Feb 6, 2025 · 5554e6a · 5554e6a
1 parent 597b87e
commit 5554e6a
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/internal/runner/service.go b/internal/runner/service.go
@@ -358,15 +358,16 @@ func (r *runnerService) Execute(srv runnerv1.RunnerService_ExecuteServer) error
 	}
 
 	opts := &startOpts{}
+	// todo(sebastian): dagger-shell is not UX integration ready yet
 	// special-case Dagger Shell to write the shell's stdout to stderr
-	if cfg.CommandMode == CommandModeDaggerShell {
-		opts.TtyAssignment = func(c *command) {
-			c.cmd.Stdin = c.tty
-			// technically wrong but in v1 we optimize for the least amount of downstream changes
-			c.cmd.Stdout = c.Stderr
-			c.cmd.Stderr = c.tty
-		}
-	}
+	// if cfg.CommandMode == CommandModeDaggerShell {
+	// 	opts.TtyAssignment = func(c *command) {
+	// 		c.cmd.Stdin = c.tty
+	// 		// technically wrong but in v1 we optimize for the least amount of downstream changes
+	// 		c.cmd.Stdout = c.Stderr
+	// 		c.cmd.Stderr = c.tty
+	// 	}
+	// }
 	if err := cmd.StartWithOpts(cmdCtx, opts); err != nil {
 		return err
 	}