Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Support #120

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

PHP 8.4 Support #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
596740e
wip
duncanmcclean Nov 25, 2024
edcdd57
Kick test suite.
jesseleite Nov 25, 2024
4704a3d
Merge branch 'master' of github.com:statamic/migrator into php84
jesseleite Nov 25, 2024
0df212c
back to original constraint
jasonvarga Nov 27, 2024
9c7c6ae
bump
jasonvarga Nov 27, 2024
c6cd4ce
fix missing quote
jasonvarga Nov 27, 2024
59003b3
We can do without this.
duncanmcclean Nov 28, 2024
5ec1788
Require Statamic 5.41
duncanmcclean Nov 28, 2024
edd6dc0
take away php 8.4 for a second
duncanmcclean Nov 29, 2024
93de876
wip
duncanmcclean Nov 29, 2024
7496bd9
wip
duncanmcclean Nov 29, 2024
3d6b163
could some of the php 8.4 fixes in newer versions of php cs fixer help?
duncanmcclean Nov 29, 2024
0e892bd
maybe try the absolute latest version then
duncanmcclean Nov 29, 2024
f9d41f3
wip
duncanmcclean Nov 29, 2024
57fddf7
wip
duncanmcclean Nov 29, 2024
686535f
put everything back to how it was
duncanmcclean Nov 29, 2024
a496e46
Merge remote-tracking branch 'origin/master' into php84
duncanmcclean Feb 20, 2025
6982acc
use current testbench versions to see if that fixes the tests
duncanmcclean Feb 26, 2025
43c3d82
ah, we need these versions of testbench
duncanmcclean Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
php: [8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]
laravel: [10.*, 11.*]
stability: [prefer-lowest, prefer-stable]
os: [ubuntu-latest]
Expand All @@ -25,9 +25,15 @@ jobs:
php: 8.3
laravel: 11.*
stability: prefer-stable
- os: windows-latest
php: 8.4
laravel: 11.*
stability: prefer-stable
exclude:
- php: 8.1
laravel: 11.*
- php: 8.4
laravel: 10.*

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"mustangostang/spyc": "dev-master#dfd9aadc1f5224065d55b42b712c7e99a50a3f4d"
},
"require-dev": {
"statamic/cms": "^5.0",
"statamic/cms": "^5.41",
"mockery/mockery": "^1.4.4",
"orchestra/testbench": "^8.0 || ^9.0",
"phpunit/phpunit": "^10.0"
"orchestra/testbench": "^8.28 || ^9.6.1",
"phpunit/phpunit": "^10.5.35"
},
"autoload": {
"psr-4": {
Expand Down
Loading