Remove ensure associations #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ryanmitchell I think this was the other culprit for all the slowness.
The
TermRepository
was calling$this->ensureAssociations();
which populates theassociations
index :This store is quite complex (over 10MB in my case) and it's probably not required when using the eloquent driver.
I also added a test to make sure the Terms facade still gets the correct count.
PS. With this change and your other PR the first page load is under 1 second.