Skip to content

Taxonomy wheres should use entry query builder, not stache #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

Taxonomy wheres should use entry query builder, not stache #432

merged 6 commits into from
May 30, 2025

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented May 29, 2025 •
edited
Loading

When getting the where's for taxonomy lookups we should do another entry query, rather than relying on stache associations. This is a big performance win when you have lots of terms.

@ryanmitchell ryanmitchell marked this pull request as ready for review May 29, 2025 10:41
@ryanmitchell ryanmitchell merged commit e0f6a14 into statamic:4.x May 30, 2025
19 checks passed
@ryanmitchell ryanmitchell deleted the fix/taxonomy-wheres-in-entry-query-builder branch May 30, 2025 06:57
faltjo pushed a commit to faltjo/eloquent-driver that referenced this pull request Jun 30, 2025
@ryanmitchell @faltjo
Taxonomy wheres should use entry query builder, not stache (statamic#432
1390f16 
)

* Taxonomy wheres should use entry query builder, not stache

* 🍺

* Scope to the right collections

* only taxonomize if we are stache

* Add some test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryanmitchell