Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix case insensitive Comb search for UTF-8 characters #11363

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

heidkaemper
Copy link
Contributor

@heidkaemper heidkaemper commented Jan 16, 2025

This pull request fixes an error in the Comb search.

The search normally operates case insensitive. To ensure that this also works with UTF-8 characters (e.g. german umlauts), the regex patterns require the "u" modifier:
https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php

We had this problem with a german website. Lets say there is the word “Ökoland” indexed. A search for “Öko” returns the correct result. But a search for “öko” (lowercase) does not. This has now been resolved with the modifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant