[5.x] Fix default values not working after saving an entry #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where default values weren't working after saving entries & terms.
When entries and terms are saved, empty values are filtered out before they get saved to the Markdown file (see
Entry::fileData()). However, that doesn't affect the data on the currentEntry/Terminstance, the empty values remain.This PR addresses that by filtering out empty values when extracting publish form values for the response.
It also updates the publish form's
meta, to address an issue where fieldtype meta would be out-of-date (in the case of the Grid fieldtype, the default values are for the old row IDs, not the new ones).Fixes #11355.