[5.x] Support non-revisable fields #11252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalzell
changed the title
|
I didn't see any tests for EntriesController nor TermsController, and honestly I was afraid to start them cuz I bet they need lots of setup. Happy to start one, with some guidance |
|
Those are in Tests\Feature\Entries\StoreEntryTest, UpdateEntry, EditEntryTest, etc. |
This was referenced Jan 2, 2025
|
Don't understand why the tests are failing, cuz one of the runs DID pass. |
|
The failing test is not your fault. 👌 #11315 If you merge 5.x back into your branch now it should be ok. |
|
@jasonvarga as term revisions aren't actually supported, this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a feature were you can sponsor an orphan. The sponsorship happens in the background (through folks signing up online).
We also have revisions. The issue is that if we want to revert back to some previous orphan data, we might be restoring a version that doesn't have a sponsorship, which will cause problems.
So we'd like to set the sponsorship fields as non-revisable so they persist.