Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Fix type error in HandleEntrySchedule job #11244

Merged
merged 2 commits into from
Dec 11, 2024
Merged

[5.x] Fix type error in HandleEntrySchedule job #11244

merged 2 commits into from
Dec 11, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes a type error caused by a CarbonImmutable instance being passed into the MinuteEntries class, rather than a plain Carbon instance.

Fixes #11239.

jasonvarga
jasonvarga requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than a Union, just change it to Carbon\CarbonInterface.

@jasonvarga jasonvarga merged commit 6adc8d4 into 5.x Dec 11, 2024
19 checks passed
@jasonvarga jasonvarga deleted the entry-schedule-carbon-immutable branch December 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HandleEntrySchedule fails when Date is configured to use CarbonImmutable instead of Carbon
2 participants
@duncanmcclean @jasonvarga