[5.x] Fix asset upload concurrency on folder upload #11225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folder upload feature from #10583 has a little flaw: while dropping a bunch of files has always uploaded the files in sequence, dropping a folder will upload all contained files at once. With lots of nested files, this might overwhelm the server and lead to corrupted uploads.
This PR fixes that by only ever allowing a single concurrent upload.
I can imagine this being a config flag to allow e.g. 3 or 5 concurrent uploads if the system can handle it.
Before
After