Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Match whereJsonContains to how Laravel handles it #11117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Nov 12, 2024

Replaces #11113

This PR updates our stache whereJsonContains (etc) implementation to match every item in the values, not any as it currently does. This brings it inline with the behaviour on the Laravel side.

This is however a breaking change so I think targeting 6.x and master is right for this (?).

The current behaviour is comparable to whereJsonOverlaps, which I've opened a seperate PR for: #11112

@ryanmitchell ryanmitchell changed the title [6.x] Match how whereJsonContains to how Laravel handles it [6.x] Match whereJsonContains to how Laravel handles it Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant