Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] PHP 8.4 Support #11114

Draft
wants to merge 4 commits into
base: 5.x
Choose a base branch
from
+8 −6
Draft

[5.x] PHP 8.4 Support #11114

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acb8235
Add PHP 8.4 to the testing matrix
duncanmcclean Nov 12, 2024
1fa1fd1
Make PHPUnit display any deprecations
duncanmcclean Nov 12, 2024
e20a562
Update `laravel/framework` version constraint
duncanmcclean Nov 12, 2024
70fb20c
wip
duncanmcclean Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:

strategy:
matrix:
php: [8.1, 8.2, 8.3]
laravel: [10.*, 11.*]
stability: [prefer-lowest, prefer-stable]
os: [ubuntu-latest]
php: [ 8.1, 8.2, 8.3, 8.4 ]
laravel: [ 10.*, 11.* ]
stability: [ prefer-lowest, prefer-stable ]
os: [ ubuntu-latest ]
include:
- os: windows-latest
php: 8.3
Expand All @@ -32,6 +32,8 @@ jobs:
exclude:
- php: 8.1
laravel: 11.*
- php: 8.4
laravel: 10.*

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

Expand Down Expand Up @@ -98,7 +100,7 @@ jobs:

- name: Execute tests
if: steps.should-run-tests.outputs.result == 'true'
run: vendor/bin/phpunit
run: vendor/bin/phpunit --display-deprecations

js-tests:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -146,7 +148,7 @@ jobs:
slack:
name: Slack Notification
runs-on: ubuntu-20.04
needs: [php-tests, js-tests]
needs: [ php-tests, js-tests ]
if: always()
steps:
- uses: technote-space/workflow-conclusion-action@v3
Expand Down
Loading