Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gimbal gazebo plugin, applying in task1 to stabilize the camera. #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tongtybj
Copy link
Member

  • [jsk_mbzirc_tasks/urdf/gimbal] Add directory for gimbal urdf description
  • [jsk_mbzirc_tasks/include/jsk_mbzirc_tasks/mbzirc_gazebo_gimbal_plugin.h, jsk_mbzirc_tasks/src/mbzirc_gazebo_gimbal_plugin.cpp]Add code about gimbal gazebo plugin, including the control about horizontal stabilization.
  • [jsk_mbzirc_tasks/urdf/quadrotor_with_hokyo30lx_and_downward_cam.urdf.xacro] Add gimbal module for camera stabilization.

@tongtybj
Copy link
Member Author

This PR is about the gimbal plugin in gazebo, which is separated from commit in #65, and was also discussed in #66

In #66 :

This is nice comparison, please describe the velocity and tilting angle of this experiment, and also check behavior of your drone with same velocity.

I redid the same experiment as shown in the gif
gimbal_short

The max tilting angle is about 30degree(0.53rad) and velocity is about 4m/s(14.4km/h).

@tongtybj
Copy link
Member Author

Is there any review or comment about this PR?

@k-okada
Copy link
Member

k-okada commented Jun 13, 2016

#85 (comment)

@tongtybj
Copy link
Member Author

both are necessary.

  • When we give a big acceleration command to a uav for horizontal movement , it will tilt with a large angle like 30 degree. With this tilt angle, we will lost the view of the arena even we have fisheye FOV. The gif in add gimbal moudle for stabilizing sensors such as camera #66 "Camera(FOV=160) without gimbal while moving rapidly" is a good example, which indicates that we will lost the truck sometime.
  • On the other hand, fisheye is also necessary, because we need very big FOV in the finally landing porces, othewise we can not capture the whole feature of heliport(I mean the "X"). Please check video in https://drive.google.com/open?id=0BwphddqBjVJ_RnYzSjh5WHJKMWc.

@tongtybj tongtybj mentioned this pull request Jun 13, 2016
3 tasks
@k-okada
Copy link
Member

k-okada commented Jun 14, 2016

ok, so you now have 160 degree of camera and the biggest tilting angle is
30 degree, so you need 160 + 30 + 30 = 220 degree angles,
from my little knowledge, we had 210 degree camera at lab
http://www.universekk.com/product/fisheye-rends.html
http://xs-optical.manufacturer.globalsources.com/si/6008849928141/pdtl/Megapixel-CCTV/1128257360/Fisheye-Lens.htm

And google knows more wider lens.
http://www.entapano.com/jp/l/

◉ Kei Okada

On Tue, Jun 14, 2016 at 6:03 AM, 趙 漠居 [email protected] wrote:

both are necessary.

When we give a big acceleration command to a uav for horizontal
movement , it will tilt with a large angle like 30 degree. With this tilt
angle, we will lost the view of the arena even we have fisheye FOV. The gif
in #66 #66
"Camera(FOV=160) without gimbal while moving rapidly" is a good example,
which indicates that we will lost the truck sometime.

On the other hand, fisheye is also necessary, because we need very big
FOV in the finally landing porces, othewise we can not capture the whole
feature of heliport(I mean the "X"). Please check video in
https://drive.google.com/open?id=0BwphddqBjVJ_RnYzSjh5WHJKMWc.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAeG3N4k8jR1Y5ldNHv5dDWOvAOf9ROzks5qLcWzgaJpZM4Izm-e
.

@tongtybj
Copy link
Member Author

@k-okada
Wonderful knowledge I never know before...
So I will do experiment about gimbal + fisheye vs superfisheye.

And, when we use superfisheye like 220 degree, should be the resolution of camera big? like 5MP?

@k-okada
Copy link
Member

k-okada commented Jun 14, 2016

And, when we use superfisheye like 220 degree, should be the resolution
of camera big? like 5MP?

this is exactly what we want to test with in simulator.

◉ Kei Okada

On Tue, Jun 14, 2016 at 10:14 AM, 趙 漠居 [email protected] wrote:

@k-okada https://github.com/k-okada
Wonderful knowledge I never know before...
So I will do experiment about gimbal + fisheye vs superfisheye.

And, when we use superfisheye like 220 degree, should be the resolution of
camera big? like 5MP?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAeG3I-3IKRktmZoCXnCKQLgxTL7q4upks5qLgBkgaJpZM4Izm-e
.

@tongtybj
Copy link
Member Author

@iKrishneel

Could you please change the FOV to 220 degree, and see the performance of your visual detection about the heliport.

@cretaceous-creature
Copy link
Collaborator

seems we cant change the hfov above 180, error will happen..
[image: 埋め込み画像 1]

2016-06-14 10:28 GMT+09:00 趙 漠居 [email protected]:

@iKrishneel https://github.com/iKrishneel

Could you please change the FOV to 220 degree, and see the performance of
your visual detection about the heliport.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIjRmYxLx7DHNwMcaaKGHPzSyLfambrRks5qLgPPgaJpZM4Izm-e
.

@tongtybj
Copy link
Member Author

Yeah, I know that bug...
And I can not see your image...

@cretaceous-creature
Copy link
Collaborator

Exception [Camera.cc:221] Camera horizontal field of view invalid

2016-06-14 11:35 GMT+09:00 趙 漠居 [email protected]:

Yeah, I know that bug...
And I can not see your image...


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIjRmRnMVHtt0zaeinQFE5wKTaAcSuN_ks5qLhN4gaJpZM4Izm-e
.

@tongtybj
Copy link
Member Author

We can make a patch and send PR to gazebo_plugins

@iKrishneel
Copy link
Collaborator

@tongtybj perhaps the detection should work but incase if it does not work well, we can rectify the frames I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants