FIX fw5-telelogger.showStats() regression when ENABLE_OLED #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to a renamed buffer var on 9 Dec 2021(fe345f9)
|
Hi @ankostis, do you have issue with MEMS I2C driver, when ENABLED_OLED is set to 1? Want to use I2C display with One+ Model B and connect it throught molex. |
Author
|
Cannot test OLED, hav'nt got this module. Just try |
|
Hi, i have fixed that problem from your cherry pick, but now i have issue with i2c and dont know how to use both internal i2c devices and oled throught molex. Thanks for your time |
Author
|
Apologies for having to delete my fork, have now restored my PR branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stanley's fe345f9 on 9 Dec 2021 broke
showSstats()when ENABLE_OLED is defined,due to forgotten renaming of the buffer variable from
timestr->buf.