-
-
Notifications
You must be signed in to change notification settings - Fork 195
add yule_simon_lccdf #3236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
add yule_simon_lccdf #3236
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change but I think this is good to merge as is
auto dlogccdf_dalpha = digamma(ap1) - digamma(nap1); | ||
partials<0>(ops_partials)[i] += dlogccdf_dalpha; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto dlogccdf_dalpha = digamma(ap1) - digamma(nap1); | |
partials<0>(ops_partials)[i] += dlogccdf_dalpha; | |
partials<0>(ops_partials)[i] += digamma(ap1) - digamma(nap1); |
Summary
With this PR the lccdf of Yule Simon distribution is added.
See issue #3235
Expressions involved:
Derivatives w.r.t the parameter
Tests
Test is written follow the guide.
Side Effects
No.
Release notes
yule_simon_lccdf
is available if merged. Allows modeling power-law count data.Checklist
Copyright holder: Zhi Ling
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested