Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lerna to 6.x and typescript to 4.x #83

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

sammys
Copy link
Contributor

@sammys sammys commented Jan 9, 2023

This is task 1 from #356

@sammys sammys marked this pull request as ready for review January 9, 2023 08:51
@koresar koresar merged commit 0877f3c into stampit-org:master Jan 9, 2023
@koresar
Copy link
Member

koresar commented Jan 9, 2023

Thanks! Awesomesause :)

I trust your judgements, so I skipped reviewing all the 37 files and 40,000 lines. :)

Would it help if I give you more privileged access to this project?

@sammys
Copy link
Contributor Author

sammys commented Jan 9, 2023

Thanks! Awesomesause :)

I trust your judgements, so I skipped reviewing all the 37 files and 40,000 lines. :)

In this case I'd say that was a wise choice hehe. It was predominantly TS compiling differently and maybe even eslint reformatting everything.

Would it help if I give you more privileged access to this project?

Might save you from dealing with boilerplate changes like this one. Even if you do give me that level of access I reckon your review might be necessary for the upcoming type changes since there's a chance I won't cover edge cases you know about.

@koresar
Copy link
Member

koresar commented Jan 9, 2023

Makes sense. Then I'll just wait for the next PRs.

I'm super pumped about this whole TS thing. Would be very useful!

@koresar
Copy link
Member

koresar commented Jan 9, 2023

@sammys not sure, but looks like I've given you Admin access to this repo. Enjoy.

@sammys
Copy link
Contributor Author

sammys commented Jan 10, 2023

Moved the issue post from stampit to #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants