iOS Route Overview #330
iOS Route Overview #330
Conversation
| ) | ||
| } | ||
|
|
||
| return MapViewCamera.boundingBox(bounds, edgePadding: UIEdgeInsets(top: 20, left: 100, bottom: 20, right: 100)) |
There was a problem hiding this comment.
The padding values are silly because the implementation in the MapLibre SwiftUI DSL seems to be broken.
| if let overviewCamera = navigationState?.routeOverviewCamera { | ||
| camera = overviewCamera | ||
| } | ||
| } : .showRecenter { // TODO: Third case when not navigating! |
There was a problem hiding this comment.
TBD the best way to express this logic given the limits of view code; probably in an extension / helper function.
| /// Determines which camera control is shown in the navigation inner grid view. | ||
| public enum CameraControlState { | ||
| /// Don't show any camera control. | ||
| case hidden | ||
|
|
||
| /// Shows the recenter button. | ||
| /// | ||
| /// The action is responsible for resetting the camera | ||
| /// to a state that follows the user. | ||
| case showRecenter(() -> Void) | ||
|
|
||
| /// Shows the route overview button. | ||
| /// | ||
| /// The action is responsible for transitioning the camera to an overview of the route. | ||
| case showRouteOverview(() -> Void) | ||
| } |
There was a problem hiding this comment.
This is the first significant design decision. I think that an enum makes the camera control states significantly cleaner to express. We can add more later if necessary, but the common ones are here.
| // TODO: Extract to a separate view? | ||
| switch cameraControlState { | ||
| case .hidden: | ||
| // Nothing | ||
| EmptyView() | ||
| case let .showRecenter(onCenter): | ||
| NavigationUIButton(action: onCenter) { | ||
| Image(systemName: "location.north.fill") | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 18, height: 18) | ||
| } | ||
| .shadow(radius: 8) | ||
| case let .showRouteOverview(onRouteOverview): | ||
| NavigationUIButton(action: onRouteOverview) { | ||
| Image(systemName: "point.bottomleft.forward.to.point.topright.scurvepath") | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 18, height: 18) | ||
| } | ||
| .shadow(radius: 8) | ||
| } |
There was a problem hiding this comment.
The important thing to note here is that we have moved the recenter button to be in the top corner. The logic behind that is that we probably only ever care about having one camera button visible at a time in my opinion (differing opinions welcome :D). So the camera button slot will either be a recenter button, a route overview button, or hidden, depending on state driven higher up.
There was a problem hiding this comment.
Discussed; we will move the recenter button to the bottom left corner to keep with convention.
| } bottomLeading: { | ||
| bottomLeading?() |
There was a problem hiding this comment.
Undo this change; recenter will stay in lower left corner.
| // TODO: Extract to a separate view? | ||
| switch cameraControlState { | ||
| case .hidden: | ||
| // Nothing | ||
| EmptyView() | ||
| case let .showRecenter(onCenter): | ||
| NavigationUIButton(action: onCenter) { | ||
| Image(systemName: "location.north.fill") | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 18, height: 18) | ||
| } | ||
| .shadow(radius: 8) | ||
| case let .showRouteOverview(onRouteOverview): | ||
| NavigationUIButton(action: onRouteOverview) { | ||
| Image(systemName: "point.bottomleft.forward.to.point.topright.scurvepath") | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 18, height: 18) | ||
| } | ||
| .shadow(radius: 8) | ||
| } |
There was a problem hiding this comment.
Discussed; we will move the recenter button to the bottom left corner to keep with convention.
Opening this as a draft PR because there are still a few problems with it, but I want feedback on the overall approach. I'll leave comments to guide the first review.
Ignore the terrible quality of simulator animated GIFs... it is not really that choppy, but it DOES take too long to get back to the user's real position because of intermediate camera updates, which is a problem we'll need to fix.