Upcoming instructions android #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthetechie
commented
Oct 30, 2024
android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/InstructionsView.kt
Outdated
Show resolved
Hide resolved
Archdoog
reviewed
Oct 30, 2024
android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/InstructionsView.kt
Outdated
Show resolved
Hide resolved
android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/InstructionsView.kt
Outdated
Show resolved
Hide resolved
android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/InstructionsView.kt
Show resolved
Hide resolved
Archdoog
reviewed
Oct 31, 2024
android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/InstructionsView.kt
Outdated
Show resolved
Hide resolved
ianthetechie
commented
Nov 1, 2024
| @@ -33,5 +33,5 @@ object DefaultInstructionRowTheme : InstructionRowTheme { | |||
| @Composable get() = MaterialTheme.colorScheme.onSurface | |||
|
|
|||
| override val backgroundColor: Color | |||
| @Composable get() = MaterialTheme.colorScheme.surface | |||
| @Composable get() = MaterialTheme.colorScheme.surfaceContainerLow | |||
There was a problem hiding this comment.
FWIW this came from the Material 3 spec
There was a problem hiding this comment.
My only comment on this is:
When material theme is used, the more complex the value is, the less likely someone has it in their theme. This isn't so much a problem. More just a warning when someone asks why their instructions row isn't changing color. It'll be because people rarely set those very nuanced values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248.
trim.29B08B24-CD4F-4104-9A7F-ED50EAB6DD2C.MOV