Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More realistic GPS simulation with consistent lateral offset #323

Conversation

engali94
Copy link
Contributor

@engali94 engali94 commented Oct 29, 2024

More realistic GPS simulation with consistent lateral offset

Current Behavior

The current simulated location provider follows route coordinates exactly, which doesn't reflect real-world GPS behavior. This makes it difficult to properly test route-snapping and other location-based features under realistic conditions.

Proposed Changes

Add support for simulated GPS inaccuracy by implementing consistent lateral offset from the route line.

Closes #322.

Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few comments. In particular I'm wondering about why the snapshot tests changed. You can resolve the formatting lint failure with cargo fmt.

common/ferrostar/src/simulation.rs Show resolved Hide resolved
common/ferrostar/src/simulation.rs Show resolved Hide resolved
common/ferrostar/src/simulation.rs Outdated Show resolved Hide resolved
common/ferrostar/src/simulation.rs Outdated Show resolved Hide resolved
@ianthetechie ianthetechie merged commit 649a68c into stadiamaps:main Oct 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More realistic GPS simulation with consistent lateral offset
2 participants