-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nisar sim v2 #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your efforts.
- Probably for later versions, we might need to add properties from here: https://github.com/stac-extensions/sar. Specifically,
product type
,frequency
, etc. - Also, is
RRSD
a good key name for a general audience? I am not sure if the asset names should target a general audience or domain scientists butRRSD
is difficult to interpret IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jjfrench
I have a couple questions that came up while reading this. Maybe they could be briefly addressed if you provide a brief description of the changes made in this PR. I see two general changes, that you could maybe shed light on with just a couple lines in the description.
- dependencies management (see my comments)
- application changes (changes to
src/stactools/nisar_sim
and related changes intests
)
Thanks !
Thanks for the feedback @emileten, let me know if you have any other questions! Feel free to resolve conversations if I was able to answer your question. |
Thanks so much for the explanations @jjfrench! Feel free to merge, I resolved the conversations. |
Before you submit a pull request, please fill in the following:
Description:
Slimming down the NISAR-sim package to reflect the latest simulated NISAR data.
Removed:
Modified:
This latest simulated NISAR package is based on the latest simulated NISAR product suite: https://nisar.jpl.nasa.gov/data/sample-data/, where there are 10 different data products with relatively the same h5 structure (with the exception of Soil Moisture).
PR checklist:
scripts/format
).scripts/lint
).scripts/test
).