Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions to help create sighashes #805

Merged
merged 19 commits into from
Nov 12, 2024

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Nov 9, 2024

Description

Closes #804.

Changes

  • Add a new table that is similar to some of our sweep table.
  • Write to this new table when we write sweep transactions and donations.
  • Update the get_signer_utxo function to use a new sweep table. That's most of these changes.
  • Add function that validates an individual deposit.

Testing Information

This needs an integration test for the block observer.

Edit: This code was changed in #822, and I add an integration test there.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Nov 9, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Nov 9, 2024
@djordon djordon self-assigned this Nov 9, 2024
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're not done but here's my comments so far

signer/migrations/0004__create_functions.sql Outdated Show resolved Hide resolved
signer/src/bitcoin/validation.rs Show resolved Hide resolved
signer/src/storage/postgres.rs Show resolved Hide resolved
@djordon djordon marked this pull request as ready for review November 11, 2024 18:49
Base automatically changed from 802-implement-validation-of-deposit-fees to main November 12, 2024 13:51
@djordon djordon merged commit 818ac00 into main Nov 12, 2024
4 checks passed
@djordon djordon deleted the 804-add-functions-for-creating-sighashes branch November 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Add helper functions for creating sighashes during validation
2 participants