Skip to content

Conversation

sveno1990
Copy link
Contributor

Description

A small type-o in the ui.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • [] CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Not applicable

@sveno1990 sveno1990 requested a review from a team as a code owner October 10, 2025 10:06
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

Hi @sveno1990. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 10, 2025
@sveno1990 sveno1990 changed the title Fix type-o cpu limit Fix(ui): type-o cpu limit Oct 10, 2025
@sveno1990 sveno1990 changed the title Fix(ui): type-o cpu limit fix(ui): type-o cpu limit Oct 10, 2025
@janisz janisz requested a review from vjwilson October 13, 2025 15:52
@janisz
Copy link
Contributor

janisz commented Oct 13, 2025

Thank you!

@janisz
Copy link
Contributor

janisz commented Oct 13, 2025

Actually we have more of this dialect :)

roxctl/utils/formatting_writer.go:              tokenScanner.Split(wordsAndDelimeters)
roxctl/utils/utils.go:// wordsAndDelimeters is a bufio.SplitFunc function that yields words and
roxctl/utils/utils.go:func wordsAndDelimeters(data []byte, atEOF bool) (int, []byte, error) {
roxctl/utils/utils.go:          i = max(i, 1) // i==0 if data starts with a delimeter.
roxctl/utils/utils_test.go:func Test_wordsAndDelimeters(t *testing.T) {
roxctl/utils/utils_test.go:             sc.Split(wordsAndDelimeters)

@janisz
Copy link
Contributor

janisz commented Oct 13, 2025

/ok-to-test

@janisz
Copy link
Contributor

janisz commented Oct 13, 2025

@sveno1990 There is no need to update, I'll handle CI failures by retesting

@janisz janisz enabled auto-merge (squash) October 13, 2025 18:44
@janisz janisz merged commit 2c6b538 into stackrox:master Oct 13, 2025
108 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor To put on issues and PRs from external contributors hacktoberfest hacktoberfest-accepted ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants