Skip to content

Conversation

parametalol
Copy link
Contributor

Description

Using onChange to wait for the results.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@parametalol parametalol requested review from a team and stehessel October 9, 2025 14:34
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 0cd6156.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-1034-g0cd6156062.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.83%. Comparing base (796e1d9) to head (0cd6156).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17227      +/-   ##
==========================================
- Coverage   48.84%   48.83%   -0.02%     
==========================================
  Files        2717     2717              
  Lines      203253   203218      -35     
==========================================
- Hits        99286    99248      -38     
- Misses      96150    96153       +3     
  Partials     7817     7817              
Flag Coverage Δ
go-unit-tests 48.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol
Copy link
Contributor Author

/retest

@parametalol parametalol changed the title fix(test): race in test ROX-31222: fix race in test Oct 13, 2025

manager.mutex.RLock()
defer manager.mutex.RUnlock()
assert.Equal(t, []byte(c.expected), manager.stsConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should test observed behaviour not internal state changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants