Add WithPredicate() option to support custom event filtering #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for custom predicates to filter reconciliation events,
which is critical for multi-controller scenarios where status-only updates
should not trigger expensive helm dry-runs.
Changes:
- Add customPredicates []predicate.Predicate field to Reconciler
- Add WithPredicate() option to configure custom predicates
- Update setupWatches() to include custom predicates in watch configuration
Example usage:
reconciler.WithPredicate(predicate.GenerationChangedPredicate{})
This allows operators to skip reconciliation when only status/metadata
changes, preventing unnecessary helm dry-runs that can cause significant
load in environments with many CRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for custom predicates to filter reconciliation events, which is critical for multi-controller scenarios where status-only updates should not trigger expensive helm dry-runs.
Changes:
Example usage:
reconciler.WithPredicate(predicate.GenerationChangedPredicate{})
This allows operators to skip reconciliation when only status/metadata changes, preventing unnecessary helm dry-runs that can cause significant load in environments with many CRs.