-
Couldn't load subscription status.
- Fork 29
ROX-30918, ROX-31049: Update labels, fix docker mediaType #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2568 +/- ##
=======================================
Coverage 28.79% 28.79%
=======================================
Files 95 95
Lines 5796 5796
Branches 2551 2551
=======================================
Hits 1669 1669
Misses 3409 3409
Partials 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest collector-on-push |
|
/retest collector-on-push |
e9d55d7 to
b2819bf
Compare
preserving order found in stackrox/stackrox, see https://github.com/stackrox/stackrox/blob/master/image/rhel/konflux.Dockerfile The separation existed for collector/collector-slim but that's not the thing any more and so merging `LABEL`-s.
as suggested in #2453
via `BUILD_TIMESTAMP` param.
b2819bf to
e179ea7
Compare
|
Adapted check script: #!/usr/bin/env bash
set -euo pipefail
tag="3.23.x-9-ge179ea73b7-fast"
parent="quay.io/rhacs-eng"
repos=(release-collector)
arch_suffixes=(amd64 s390x ppc64le arm64)
echo " >>> Checking mediaType on indexes"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
echo " >>> on ${index}"
skopeo inspect --raw "docker://${index}" | jq | grep mediaType
done
echo " >>> Checking mediaType on images"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
for arch in "${arch_suffixes[@]}"; do
image="${index}-${arch}"
echo " >>> on ${image}"
skopeo inspect --raw "docker://${image}" | jq | grep mediaType
done
done
echo " >>> Checking labels on images"
for repo in "${repos[@]}"; do
index="${parent}/${repo}:${tag}"
for arch in "${arch_suffixes[@]}"; do
image="${index}-${arch}"
echo " >>> on ${image}"
skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'
done
done |
Description
See stackrox/scanner#2300.
Checklist
[ ] Updated documentation accordinglyAutomated testing
No change.
Testing Performed
Checked the results with my script, see below.