Skip to content

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Oct 13, 2025

Description

See stackrox/scanner#2300.

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

No change.

Testing Performed

Checked the results with my script, see below.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.79%. Comparing base (887fa2b) to head (e179ea7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   28.79%   28.79%           
=======================================
  Files          95       95           
  Lines        5796     5796           
  Branches     2551     2551           
=======================================
  Hits         1669     1669           
  Misses       3409     3409           
  Partials      718      718           
Flag Coverage Δ
collector-unit-tests 28.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov
Copy link
Contributor Author

/retest collector-on-push

@msugakov
Copy link
Contributor Author

/retest collector-on-push

preserving order found in stackrox/stackrox, see
https://github.com/stackrox/stackrox/blob/master/image/rhel/konflux.Dockerfile

The separation existed for collector/collector-slim but that's not
the thing any more and so merging `LABEL`-s.
as suggested in #2453
@msugakov msugakov force-pushed the misha/ROX-30918-update-labels branch from b2819bf to e179ea7 Compare October 15, 2025 10:16
@msugakov msugakov changed the title ROX-30918: Update labels ROX-30918, ROX-31049: Update labels, fix docker mediaType Oct 15, 2025
@msugakov
Copy link
Contributor Author

Adapted check script:

#!/usr/bin/env bash

set -euo pipefail

tag="3.23.x-9-ge179ea73b7-fast"
parent="quay.io/rhacs-eng"
repos=(release-collector)
arch_suffixes=(amd64 s390x ppc64le arm64)

echo " >>> Checking mediaType on indexes"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"
  echo "  >>> on ${index}"
  skopeo inspect --raw "docker://${index}" | jq | grep mediaType
done

echo " >>> Checking mediaType on images"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"

  for arch in "${arch_suffixes[@]}"; do
    image="${index}-${arch}"
    echo "  >>> on ${image}"
    skopeo inspect --raw "docker://${image}" | jq | grep mediaType
  done
done

echo " >>> Checking labels on images"

for repo in "${repos[@]}"; do
  index="${parent}/${repo}:${tag}"

  for arch in "${arch_suffixes[@]}"; do
    image="${index}-${arch}"
    echo "  >>> on ${image}"
    skopeo inspect --no-tags "docker://${image}" | grep -E '"(cpe|name|org.opencontainers.image.created)"'
  done
done

@msugakov msugakov requested a review from tommartensen October 15, 2025 11:39
@msugakov msugakov marked this pull request as ready for review October 15, 2025 11:39
@msugakov msugakov requested review from a team and rhacs-bot as code owners October 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants