View/textSelectionEnabled #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrk24
reviewed
Oct 11, 2025
|
|
||
| public func createTextView() -> Widget { | ||
| let widget = WrapperWidget<UILabel>() | ||
| widget.child.numberOfLines = 0 |
There was a problem hiding this comment.
Does the subclass do something that makes it unnecessary? With plain UILabel, forgetting this means multiline text doesn't work, and I don't see anywhere in the subclass that sets this property.
There was a problem hiding this comment.
Thank you, I read the description of this property wrong, leading to me thinking 0 was the default value.
|
yas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Philocalyst requested I added a modifier to control wether Text() could be selected by the user.
On UIKitBackend I switched from UILabel to a new Class inheriting from UILabel to show a Menu on long press.
Oob selectability is not built into UILabels.
I tested using UITextView like NSTextView in the AppKitBackend, but it lead to rendering issues.
The custom class solution should work as a drop in replacement, rendering exactly the same as before, only with more funktionality.
The isTextSelectionEnabled boolean gets set in the environment.
AppKitBackend, WinUIBackend and GtkBackend required a single line change in the updateTextView function, setting the flag on the native View.
On AppKitBackend the cursor is not always reacting to a change in the reactability instantly and it also doesn’t unselect it (Gtk and WinUI do unselect it) but this seems to be an AppKit Limitation and shouldn't affect the majority of usecases.
I’m sorry for the huge amount of confusing added and removed top level files, I assume a compile process placed them there for some reason.
It should be mergable with my other pr without conflicts.