-
-
Notifications
You must be signed in to change notification settings - Fork 57
Add compatibility for legacy iOS #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also, I added my UIKitCompatKit which I am developing partially for this, which does a lot of the heavy lifting in the backend, |
Update: It now builds, but crashes. I am not entirely sure why, because I don't know the details of this repo very well. I am assuming it is one of the classes I marked as iOS 13+, if one of you could let me know which it is that would cause crashes that'd be great, so I can work on either bypassing or shimming it. |
…of weak dependency on it
…to serve a purpose and 2, break compatibility with iOS 6, as they implicitly call atomic_store. This is now patched by removing them
Removed a bunch of commits related to iOS 7 compatibility, however, i have now patched the repo to seemingly be fully working on iOS 10+. Of course, all iOS 10+ methods are disabled because the target is iOS 7, but, this is a decent proof of concept that this can work. I have reached the end of what I can reasonably do without help, as I do not really understand the inner workings of this repo. I have hopes that this repo can be able to run on iOS 6+, but as it stands, iOS 10+ should 100% be considered as a reasonable target. |
037ae5d
to
b23b7e4
Compare
Please do not merge unless you are happy to remove everything I have done. I advise you review my changes, most do not impact your framework whatsover. I have preserved Concurrency basically everywhere, and provided fallback functions for older iOS versions. Let me know of anything you want me to do. Once everything is complete, you can merge. I will change the Package.swift to something better if you like, but currently, the way I have it is the only way it compiles.