Add integration tests for vMCP server #2624
Merged
+905
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2624 +/- ##
==========================================
- Coverage 55.47% 55.03% -0.45%
==========================================
Files 312 315 +3
Lines 29714 29952 +238
==========================================
Hits 16485 16485
- Misses 11789 12027 +238
Partials 1440 1440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
force-pushed
the
vmcp-integration
branch
from
ac0d8f3 to
c6612a8
Compare
yrobla
reviewed
Nov 18, 2025
amirejaz
previously approved these changes
Nov 18, 2025
Contributor
|
LGTM, Yolanda has some comments. |
Contributor
Author
it's just part of |
The tests use real MCP backend servers created with mark3labs/mcp-go SDK to ensure authentic protocol behavior. Test helpers in test/integration/vmcp/helpers/ provide reusable utilities for creating vMCP servers, MCP clients, backend servers, and common test assertions.
Use select statement instead of ctx.Err() check to avoid race condition when checking for context cancellation in the goroutine error handler. This follows Go best practices for context handling. Addresses review comment from @yrobla.
jhrozek
force-pushed
the
vmcp-integration
branch
from
411ccbe to
f3ad1ac
Compare
yrobla
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests use real MCP backend servers created with mark3labs/mcp-go SDK to ensure authentic protocol behavior.
Test helpers in test/integration/vmcp/helpers/ provide reusable utilities for creating vMCP servers, MCP clients, backend servers, and common test assertions.