Skip to content

Conversation

@kantord
Copy link
Member

@kantord kantord commented Dec 12, 2025

this sets up "end to end" testing for the project:

  • sets up a runner to run playwright tests written as feature files
  • adds a very convenient way to use ARIA-role based steps, plus a way to remap "ugly" ARIA roles, such as being able to write "list item" instead of "listitem" for a more natural-sounding English
  • adds a simple helper for authentication: log in once and recycle cookies across different tests to avoid redundancy in E2E tests to keep them fast

gotchas:

  • does not actually target a real BE yet, since that is not yet configured. it should be pretty easy to do it using testcontainers even being able to use different scenarios with different containers. but since BE won't return any interesting data yet this is pointless
  • i avoided writing any tests targeting MSW data because that would not be very useful, but this is 100% possible to do if it's needed for whatever reason

@github-actions github-actions bot added the size/XL Extra large PR: 1000+ lines changed label Dec 12, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large PR Detected

This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.

How to unblock this PR:

Add a section to your PR description with the following format:

## Large PR Justification

[Explain why this PR must be large, such as:]

- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformation

Alternative:

Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.

See our Contributing Guidelines for more details on the pull request process.


This review will be automatically dismissed once you add the justification section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE size/XL Extra large PR: 1000+ lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants