Multinode workflow: use github user's ssh key #2036
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Multiline input is not supported in github actions, see So the ssh_key input still only supports a single key. If we want to extend this, we could check if the first character is a square bracket ( Should I implement that? |
skip-checks:true
| name: Multinode | ||
| uses: stackhpc/stackhpc-openstack-gh-workflows/.github/workflows/[email protected] | ||
| needs: github_user_ssh_keys | ||
| uses: stackhpc/stackhpc-openstack-gh-workflows/.github/workflows/[email protected] |
There was a problem hiding this comment.
This is an important change going under the radar. What's actually included here?
There was a problem hiding this comment.
It's the support for the ssh_keys input in our multinode generic workflow.
Please see stackhpc/stackhpc-openstack-gh-workflows#17
| # Workaround loss of number type using fromJSON: https://github.com/orgs/community/discussions/67182 | ||
| break_duration: ${{ fromJSON(inputs.break_duration) }} | ||
| ssh_key: ${{ inputs.ssh_key }} | ||
| ssh_keys: ${{ needs.github_user_ssh_keys.outputs.ssh_keys }} |
There was a problem hiding this comment.
If we're no longer passing ssh_key through, please remove it from the inputs at the start of the workflow
There was a problem hiding this comment.
yes, you're right.
Thank you
Co-authored-by: Alex Welsh <[email protected]>
changes to stackhpc-multinode.yml:
github_user_ssh_keysinput (defaults to true)ssh_keyis still here and overridesgithub_user_ssh_keys