Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions etc/kayobe/kolla/config/neutron/policy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"create_port:fixed_ips:ip_address": "(rule:admin_only) or (rule:service_api) or role:manager and project_id:%(project_id)s or role:member and rule:network_owner or role:baremetaluser"
"create_port:mac_address": "(rule:admin_only) or (rule:service_api) or role:manager and project_id:%(project_id)s or role:member and rule:network_owner or role:baremetaluser"
Comment on lines +1 to +2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and to avoid any ambiguity with operator precedence, it's a good practice to wrap and expressions in parentheses. While and has higher precedence than or in OpenStack policy rules, explicit grouping makes the policy easier to understand and maintain.

"create_port:fixed_ips:ip_address": "(rule:admin_only) or (rule:service_api) or (role:manager and project_id:%(project_id)s) or (role:member and rule:network_owner) or role:baremetaluser"
"create_port:mac_address": "(rule:admin_only) or (rule:service_api) or (role:manager and project_id:%(project_id)s) or (role:member and rule:network_owner) or role:baremetaluser"

2 changes: 2 additions & 0 deletions etc/kayobe/kolla/config/nova/policy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"os_compute_api:servers:create:forced_host": "rule:context_is_admin or role:baremetaluser"
"compute:servers:create:requested_destination": "rule:context_is_admin or role:baremetaluser"
Loading