Skip to content

Support fixed IP addresses for control node #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

priteau
Copy link
Member

@priteau priteau commented Apr 4, 2025

The variable control_ip_address was documented but not implemented. Since we support multiple networks, change it to control_ip_addresses and implement it.

Closes #642.

@priteau priteau self-assigned this Apr 4, 2025
@priteau priteau requested a review from a team as a code owner April 4, 2025 08:43
The variable control_ip_address was documented but not implemented.
Since we support multiple networks, change it to control_ip_addresses
and implement it.

Closes #642.
@sjpb sjpb force-pushed the control-ip-addresses branch from b3f0147 to bf7eb74 Compare May 29, 2025 14:22
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this isn't right - logic should be that iff the network key isn't in the map, we default to null, rather than the condition being that the map is empty. So its probably a lookup not a ternary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production variable control_ip_address is not implemented
2 participants