-
Notifications
You must be signed in to change notification settings - Fork 0
Include CephFS mount options from Manila as posix mount options. #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
defaults/main.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaults are documented in https://github.com/stackhpc/ansible-role-os-manila-mount?tab=readme-ov-file#role-variables, the behaviour of defaults also coming from the share should be documented.
Thanks @sjpb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change extracts the
__mount_options
field from the metadata of Manila shares and includes it in themount_options
variable.This field is expected to be populated only with CephFS shares.
Key functionality:
mount_options
This allows the handling of CephFS shares in Manila, where multiple CephFS pools are used within a single Ceph cluster.