Skip to content

Relax gres configuration validation to allow multiple conf keys #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

Relax gres configuration validation to allow multiple conf keys #193

merged 3 commits into from
Jun 11, 2025

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Jun 10, 2025 •
edited
Loading

Validation was too strict and did not allow multiple dictionaries in the gres definition. E.g:

  - name: gpu
    gres_autodetect: nvml
    gres:
      - conf: gpu:A100:2
      - conf: gpu:H100:2

Was forbidden (for no apparent reason).

@jovial jovial force-pushed the bugfix/gres-validate branch 7 times, most recently from 0c27f7f to 4a71c27 Compare June 10, 2025 16:41
@jovial jovial marked this pull request as ready for review June 10, 2025 16:43
@jovial jovial requested a review from a team as a code owner June 10, 2025 16:43
@jovial jovial force-pushed the bugfix/gres-validate branch from 4a71c27 to d94f96a Compare June 10, 2025 16:48
sjpb
sjpb requested changes Jun 11, 2025
View reviewed changes
jovial
jovial commented Jun 11, 2025
View reviewed changes
@sjpb sjpb self-requested a review June 11, 2025 08:48
sjpb
sjpb approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovial jovial merged commit 521ea02 into master Jun 11, 2025
29 checks passed
@jovial jovial deleted the bugfix/gres-validate branch June 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jovial @sjpb