Skip to content

release: use GITHUB_TOKEN and add issues: write for manual approval step #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcberg merged 1 commit into from
Jul 9, 2025
Merged

release: use GITHUB_TOKEN and add issues: write for manual approval step #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:

permissions:
contents: write
issues: write
id-token: write

jobs:
Expand All @@ -16,7 +17,7 @@ jobs:
- name: Wait for manual approval
uses: trstringer/manual-approval@v1
with:
secret: ${{ secrets.GH_TOKEN }}
secret: ${{ secrets.GITHUB_TOKEN }}
issue-title: "Release Approval for ${{ github.ref_name }}"
issue-body: "Please approve this release to publish to PyPI and Docker."
approvers: sgerlach,kcberg,danielhopkins,clamey,Bwvolleyball
Expand All @@ -29,11 +30,6 @@ jobs:
runs-on: ubuntu-latest
needs: approval
steps:
- name: Test GH_TOKEN permissions
run: |
curl -v -H "Authorization: token ${{ secrets.GH_TOKEN }}" \
https://api.github.com/repos/${{ github.repository }}
shell: bash
- name: Confirm release tag exists
run: |
echo "Release tag is ${{ github.ref }}"
Expand All @@ -58,11 +54,8 @@ jobs:
pip install build bumpver
- name: Set up git for pushing
run: |
git remote set-url origin https://x-access-token:${{ secrets.GH_TOKEN }}@github.com/${{ github.repository }}.git
- name: Set git user for deploy
run: |
git config user.name "${{ secrets.GH_DEPLOY_USER }}"
git config user.email "${{ secrets.GH_DEPLOY_EMAIL }}"
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
- name: Build package
run: |
python -m build
Expand All @@ -79,14 +72,10 @@ jobs:
with:
ref: ${{ github.ref }}
fetch-depth: 0
- name: Test GH_TOKEN permissions
run: |
curl -v -H "Authorization: token ${{ secrets.GH_TOKEN }}" \
https://api.github.com/repos/${{ github.repository }}
shell: bash
- name: Set up git for pushing
run: |
git remote set-url origin https://${{ secrets.GH_DEPLOY_USER }}:${{ secrets.GH_TOKEN }}@github.com/${{ github.repository }}.git
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
Expand Down