Wallet schema v2

[ekzyis]

Description

based on #2092 because it's the target branch

This PR does the following:

• add static table WalletTemplate which stores which send and receive protocols a wallet in UserWallet supports
  => allows multiple send and receive protocols per wallet
• split wallets by send and receive for easier validation of configuration instead of having both send and receive optional and rely on application logic to make sure the configuration is not invalid
• add wallet protocol tables (WalletSend..., WalletRecv...) which store configuration per user wallet
• use triggers to make sure that a protocol of a user wallet is actually supported by the wallet

How to add a new wallet:

• add a new row to the WalletV2 table and declare which send and receive protocols it supports
• if it supports a new protocol, update enums and add a new wallet protocol table to store configuration

My beautiful TODO list

• use unique index for walletId in wallet protocol tables so a user wallet can't have the same protocol twice for the same wallet ✅
• check if HTTP protocols to send and recv (LNbits, Blink, Phoenixd) can be abstracted away via one WalletSendHTTP table without resorting to JSON columns ❌ won't do in this PR, maybe in the future
• check if trigger to check wallet support can be unified ✅
• wallet migration ✅
  • wallet seed ✅
  • eliminate duplicate wallets before migration (Delete duplicate wallets #2163) ✅
  • migrate wallets ✅
  • wallet seed with multiple wallets (LNbits, NWC, ...) per user ✅
  • put send/receive protocols into the same user wallet if exists ✅
  • verify wallet migration with SQL assertions after migration ❌ decided not to, too much work
  • add trigger to update JSON in ProtocolWallet row ✅
    • split JSON column into two columns for send and receive? ❌ no longer needed since we switched to ProtocolWallet
    • resolve vault entries in JSON trigger ✅
  • drop old tables, triggers etc. ✅
  • keep ids stable during migration to make new foreign keys work ✅
• figure out why Withdrawal foreign key fails ✅ fixed it, but didn't really figure out what happened
• Q: Are there more edge cases with our old wallets that might break migration? ✅ No, I don't think so.
• Q: add priority to ProtocolWallet, too? ✅ No, I don't think that's important and we can change it later.
• verify wallet support 🚧
• update code to save/load wallets 🚧
• rename walletId foreign keys that point to UserWallet to userWalletId to avoid confusion? 🤔
• add User(id, vaultKeyHash) foreign key to Vault table with new userId, keyHash columns? ❌ out of scope of this PR

Additional Context

This is based on the latest discussion with @huumn how to plan further ahead with the wallet schema than to just migrate the vault in #2092.

Checklist

Are your changes backwards compatible? Please answer below:

tbd

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

tbd

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
16991000	Triggered	Generic High Entropy Secret	c52b973	docker/db/wallet-seed.sql	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[ekzyis]

See #2092 (comment)